When using --source, --include is silently ignored

[nedbat]

Once --source is specified, --include is ignored. If the user specifies both, this shouldn't happen silently. A warning or error is appropriate.

---

• Bitbucket: https://bitbucket.org/ned/coveragepy/issue/265

[nedbat]

Original comment by Aldo Longhi (Bitbucket: alonghi, GitHub: alonghi)

---

Would an appropriate fix be to issue a warning (but then still return True) in CoverageScript.args_ok?

[nedbat]

@ALonghi Unfortunately, the conflict could be in the configuration file also. And run uses with --source or --include, but "report" uses only --include. I'll have to think more about what is a problem here, and what to do about it.

[nedbat]

Original comment by alsopape (Bitbucket: alsopape, GitHub: Unknown)

---

addressed this issue on the github mirror with a proposed PR #9

[nedbat]

Original comment by Loic Dachary (Bitbucket: dachary, GitHub: dachary)

---

For the record https://bitbucket.org/ned/coveragepy/pull-requests/105/source-and-include-are-mutually-exclusive/diff should fix this issue

[nedbat]

--source and --include are mutually exclusive #265

Add a sanity_check function to CoverageConfig to perform sanity checks
after configuration values have been collected from files, arguments
etc.

Raise an error if --source and --include are both set.

The config tests are amended because some of them have both source and
include set.

Based on the original patch from Nathan Land

close #265

→ <<cset 4aced78ac2a1 (bb)>>

[nedbat]

Fixed in 4aced78ac2a1 (bb)

[nedbat]

This fix was released as part of Coverage.py 4.3.

[nedbat]

Original comment by Loic Dachary (Bitbucket: dachary, GitHub: dachary)

---

The fix was incorrect and the regression was reported at https://bitbucket.org/ned/coveragepy/issues/541/coverage-43-breaks-nosetest-with-coverage. It should be re-opened. A proper implementation should separate --include into --run-include & --report-include because the options are not unique to a command / action.

[nedbat]

Original comment by Loic Dachary (Bitbucket: dachary, GitHub: dachary)

---

Reverted by https://bitbucket.org/ned/coveragepy/commits/d427811cbc79c4845ae2983c12b8775ee3c7859c

[nedbat]

Original comment by Loic Dachary (Bitbucket: dachary, GitHub: dachary)

---

New draft implementation at https://bitbucket.org/ned/coveragepy/pull-requests/119/source-and-include-are-mutually-exclusive/diff

[nedbat]

• --source and --include are mutually exclusive (take 2) When using --source, --include is silently ignored #265

close #265
close #101

→ <<cset 9519784205ba (bb)>>

[nedbat]

Belatedly add a test for #541, so we can fix #265 for real

→ <<cset c986bd0295a9 (bb)>>

[nedbat]

This is fixed again in 9519784205ba (bb).