update integration #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
| torchvision = "^0.14.0" | ||
| torch = { version = "^1.13.0", optional = true } | ||
| torchvision = { version = "^0.14.0", optional = true } | ||
| neptune = { version = ">=1.0.0", optional = true } |
There was a problem hiding this comment.
I think detectron2 should also be an optional dependency. Wdyt?
There was a problem hiding this comment.
It's not that easy, as it is only installed from GitHub repo, not PyPI and I've been having issued with adding that to poetry (that's why there is a seperate step just to install detectron2 in out CI)
| raise ValueError(f"Update freq should be greater than 0. Got {self._metrics_update_freq}.") | ||
| if not isinstance(self._metrics_update_freq, int): | ||
| raise TypeError( | ||
| f"Smoothing window size should be of type int. Got {type(self._metrics_update_freq)} instead." |
There was a problem hiding this comment.
metrics_update_freq should be of type int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing:
neptunenorneptune-clientis part of the requirementsneptunenorneptune-clientis installed, an appropriate exception is raised with instructions for installationsmoothing_window_size->metrics_update_freq