Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video support added and default animations #15

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

vitorregisrr
Copy link
Contributor

Just call the type 'video' and the respective content.

@vitorregisrr
Copy link
Contributor Author

vitorregisrr commented Aug 29, 2018

i found a bug, plz wait to merge.
the video are running with de modal closed.

edit**
this was fixed, i'm searching on show function if there is any video label, if there is, i will play it. same logic on hide, but stoping.

@vitorregisrr vitorregisrr reopened this Aug 29, 2018
@netgfx
Copy link
Owner

netgfx commented Aug 29, 2018

Please add information on Readme.md as well

@vitorregisrr vitorregisrr changed the title video support added video support added and default animations Aug 29, 2018
@vitorregisrr
Copy link
Contributor Author

vitorregisrr commented Aug 29, 2018

Default animations 'fade' and 'scale' added. But how the game functions dont work when the game is paused, i needed to do a "quick fix". If you guess that it can be made better, just tell me the way.

@vitorregisrr
Copy link
Contributor Author

vitorregisrr commented Sep 1, 2018

The modal position was bugging when the the world bounds is manually setted.
I fixed it on showModal function.
Without the fix:
bug1

With the fix:
bug2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants