Use boringssl master in boringssl-static subproject #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This branch is already specified in the top-level project. However, when the stable branch is specified in the boringssl-static subproject, I get the stable branch when I build locally. Making the change in both places ensures there's no confusion in the build system. Modification: Change the `boringsslBranch` property to `master` in the boringssl-static subproject. Result: Local, CI, and all other builds always use the master-branch version of boringssl.
normanmaurer
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This branch is already specified in the top-level project. However, when the stable branch is specified in the boringssl-static subproject, I get the stable branch when I build locally. Making the change in both places ensures there's no confusion in the build system.
Modification:
Change the
boringsslBranchproperty tomasterin the boringssl-static subproject.Result:
Local, CI, and all other builds always use the master-branch version of boringssl.