Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax deepdiff dependency. #101

Merged

Conversation

Kircheneer
Copy link
Contributor

No description provided.

@Kircheneer
Copy link
Contributor Author

@chadell
Copy link
Collaborator

chadell commented May 12, 2023

this allows moving to a new major version (6.0.0). Not sure if this is desirable...

@Kircheneer
Copy link
Contributor Author

Doesn't look problematic to me:

v6-0-0

[Exclude obj callback strict](https://github.com/seperman/deepdiff/pull/320/files) parameter is added to DeepDiff by Mikhail Khviyuzov [mskhviyu](https://github.com/mskhviyu).

A fix for diffing using iterable_compare_func with nested objects by [dtorres-sf](https://github.com/dtorres-sf) who originally contributed this feature.

One looks like a bug fix and the other is a new feature.

https://zepworks.com/deepdiff/current/changelog.html

Co-authored-by: Patryk Szulczewski <[email protected]>
pszulczewski
pszulczewski previously approved these changes May 12, 2023
@pszulczewski
Copy link
Collaborator

@Kircheneer you need to update poetry.lock

@pszulczewski pszulczewski dismissed their stale review May 12, 2023 11:22

Update poetry.lock

@Kircheneer
Copy link
Contributor Author

I don't think so @pszulczewski - I am just allowing newer versions, I am not necessitating their use.

@pszulczewski
Copy link
Collaborator

From the CI:
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it.

@lvrfrc87
Copy link
Collaborator

Would be nice to have it in poetry lock so CICD can run with the latest lib version an mack sure all test are ok

@Kircheneer Kircheneer force-pushed the lk-relax-deepdiff-dependency branch from 6396ae8 to a1ff40c Compare May 12, 2023 12:02
@Kircheneer
Copy link
Contributor Author

Ahh I see.. done!

@pszulczewski pszulczewski merged commit 82ba480 into networktocode:develop May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants