Add support for Meson build system used by Pulseaudio 15 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- config.h is now search for under PULSE_DIR - Location of config.h can be specified explicitly with PULSE_CONFIG_DIR - Extra warning if PULSE_DIR appears to be invalid
matt335672
force-pushed
the
pa15_support
branch
from
d03efbd to
c4a4e89
Compare
|
Added a second commit to support PA15/Meson in Ubuntu build scripts. Thanks to @mrmotallebi for pointing out that Ubuntu 21.10 uses PA 15. Retested on Ubuntu versions 21.10 / 20.04 / 18.04 / 16.04. |
|
@matt335672 I would like to make a new release when this is merged. |
|
Just merged #69 to remove some tabs which crept into a script when I was editing it on a 2110 VM. I've got nothing else to contribute for a new release. Comments have been positive so far. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Pulseaudio 15 uses the Meson build system rather than autotools for configuration. As a result, the pulseaudio
config.hfile is not located in$PULSE_DIRThere is no fixed location for
config.hwhen Meson is used - it depends on howmeson buildis actually called.In the course of investigating #58, the following was determined:-
rpmbuild/mock,config.his in$PULSE_DIR/redhat-linux-buildmeson buildon the command line,config.his in$PULSE_DIR/buildPKGBUILD,config.his in$PULSE_DIR/../build/This PR implements the following logic:-
PULSE_CONFIG_DIRis not defined,./configuresearches forconfig.hin$PULSE_DIRdown a maximum 3 levels.PULSE_CONFIG_DIRis defined./configureexpectsconfig.hto be in the directory$PULSE_CONFIG_DIR/The search is adequate to support existing autotools functionality, F35 and a basic call to
meson build. For these distros the build interface is the same.If the search does not locate
config.h(i.e. Manjaro/Arch and probably others), the location can be specified explicitly.Additionally a warning is now generated if PULSE_DIR is defined but does not appear to be correct.