plasma 5.26 does not like PA_PROP_DEVICE_CLASS abstract #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually for plasma 5.27 to work correctly it seems that we need to create "cards". I will have a look when I find some time |
akarl10
force-pushed
the
soundcard-class
branch
from
c2f7a33 to
70df8a4
Compare
akarl10
force-pushed
the
soundcard-class
branch
from
649dc97 to
133a685
Compare
matt335672
requested changes
Feb 2, 2023
| pa_device_port_new_data_set_description(&data, "xrdp output"); | ||
| pa_device_port_new_data_set_direction(&data, PA_DIRECTION_OUTPUT); | ||
| pa_device_port_new_data_set_available(&data, PA_AVAILABLE_YES); | ||
| pa_device_port_new_data_set_type(&data, PA_DEVICE_PORT_TYPE_NETWORK); |
There was a problem hiding this comment.
pa_device_port_new_data_set_type() was added for PA 14 (pull request here). This line fails to compile on Ubuntu 20.04 and CentOS 7. I'd suggest bracketing it with a version test like this:-
#if defined(PA_CHECK_VERSION) && PA_CHECK_VERSION(14, 0, 0)
pa_device_port_new_data_set_type(&data, PA_DEVICE_PORT_TYPE_NETWORK);
#endifaccording to doxygen only "sound", "modem", "monitor", "filter" are allowed. Use sound as this is the most appropriate also plasma-pa hides virtual devices by default. flag them as hardware since to the user this virtual card behaves like that. It is not some kind of filter or secondary output
akarl10
force-pushed
the
soundcard-class
branch
from
b13502b to
0a1fd9a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to doxygen only
"sound", "modem", "monitor", "filter"
are allowed. Use sound as this is the most appropriate