Step3 #4192
Open
Step3 #4192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이전 마지막 피드백에서 말씀해주신 LottoMatcher 로직까지 굳이 꺼내야하나라고 생각하면서 로직을 도출 후 스텝3를 진행해 보니 알차게 사용할 수 있었습니다.
아직 어느정도까지 일급객체를 만들어야하나 고민이 되는데 BonusNumber 같은 경우 하나의 숫자이지만 validation 기능을 넣어서 따로 객체를 만들어 볼까 생각했는데 parser에 이미 필요 정보들이 다 들어 있어서 parser에 메소드를 추가하는 형식으로 진행해보았습니다.