Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5단계 - 자동차 경주(리팩토링) #6124

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

yooncheolkim
Copy link

view, domain으로 패키지 분리하였습니다.
4단계 마지막에 리뷰주신 내용들 적용하였습니다.
리뷰 부탁드립니다 (_ _)

Copy link

@pci2676 pci2676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 구조를 잘 나누어 주셔서 그런지 5단계에서는 크게 리뷰드릴 부분이 보이지 않는것 같네요!

그동안 저와 자동차 미션 함께 수행하느라 고생 많으셨습니다. :)

merge하겠습니다. 🚀

Comment on lines +34 to 40
public void moveOnce시_남은시도가_차감된다() {
String[] carNameList = new String[]{"kim", "cheol"};
Racing racing = new Racing(carNameList, 5);
Racing racing = new Racing(carNameList, 1);
assertThat(racing.isRemainTry()).isEqualTo(true);
racing.moveUntilFinish();
racing.moveOnce();
assertThat(racing.isRemainTry()).isEqualTo(false);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이러한 테스트는 dynamicTest가 어울릴지도 모르겠네요~ 한번 찾아보시면 좋을것 같습니다. :)

@pci2676 pci2676 merged commit 5ce4bc0 into next-step:yooncheolkim Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants