-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[클린코드 7기 임호정] 영화 리뷰 미션 STEP 3 #39
Open
IMHOJEONG
wants to merge
41
commits into
next-step:imhojeong
Choose a base branch
from
IMHOJEONG:step3
base: imhojeong
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
학습 목표
Todo
비동기 🔥
설계 시 고민 사항
리뷰 요청이 늦어진 부분 죄송합니다 (나름 react 처럼 구현해보고 싶었지만, 실력 부족으로 결국 원래대로 구현하는 방식으로 변경하였습니다)
세세한 리뷰를 주셨는데, setState 관련해서 해결책을 못 찾아서, 구현에 중점을 맞추어 다시 코드를 변경 후 step3를 마무리 하였습니다.
이 방식대로 구현하고자 했지만, 이벤트 핸들러가 잘 작동하지 않는 문제가 있어서, dom component를 반환하는 코드로 변경하였습니다.
더보기 버튼을 없애고, 검색어가 있을 때만 무한 스크롤 기능이 작동하지 않도록 하였습니다.
상세보기가 열려있는 상태에서 ESC를 누르면 상세보기가 닫힙니다.