-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider) : added Epic Games provider #12772
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@yaelbrinkert is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Hi @yaelbrinkert, thanks for your contributions! I see you're working on adding a new provider, but the implementation is currently incomplete. To keep things organized and reviewable, could you:
This will help the maintainers understand your intent and provide better feedback. Looking forward to your updated PR! Thanks again. 😊 |
Hi Ben,
I'm sorry, I'll do this when I have time, I've actually never contributed
to any public library, this was my first time. I'll try to find some help
from the community to learn how to contribute, if you have any names to
give me I would appreciate it :)
Have a great week, sincerely,
Yael
Le lun. 24 mars 2025 à 15:06, Ben Hovinga ***@***.***> a
écrit :
… Hi @yaelbrinkert <https://github.com/yaelbrinkert>, thanks for your
contributions! I see you're working on adding a new provider, but the
implementation is currently incomplete.
To keep things organized and reviewable, could you:
- Consolidate your changes into a single PR instead of multiple
smaller ones.
- Ensure the feature is complete, including documentation, before
submitting.
- Review the Contributing guidelines
<https://github.com/nextauthjs/.github/blob/main/CONTRIBUTING.md>.
This will help the maintainers understand your intent and provide better
feedback. Looking forward to your updated PR! Thanks again. 😊
—
Reply to this email directly, view it on GitHub
<#12772 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASAI36JYB6Z7U4SM4DODGHL2WAGQFAVCNFSM6AAAAABY6OC7BKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBYGI2TENBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: benhovinga]*benhovinga* left a comment
(nextauthjs/next-auth#12772)
<#12772 (comment)>
Hi @yaelbrinkert <https://github.com/yaelbrinkert>, thanks for your
contributions! I see you're working on adding a new provider, but the
implementation is currently incomplete.
To keep things organized and reviewable, could you:
- Consolidate your changes into a single PR instead of multiple
smaller ones.
- Ensure the feature is complete, including documentation, before
submitting.
- Review the Contributing guidelines
<https://github.com/nextauthjs/.github/blob/main/CONTRIBUTING.md>.
This will help the maintainers understand your intent and provide better
feedback. Looking forward to your updated PR! Thanks again. 😊
—
Reply to this email directly, view it on GitHub
<#12772 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASAI36JYB6Z7U4SM4DODGHL2WAGQFAVCNFSM6AAAAABY6OC7BKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBYGI2TENBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources