fix: double-wrapped return values caused by Promise.{reject,resolve}
#1861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
Both
Promise.reject
andPromise.resolve
return aPromise
on their own. They are meant to be called inside non-async functions and serve as an escape hatch when nativeasync
/await
syntax isn’t available.The code of NextAuth is transpiled, though, so all the async functions already return a
Promise
by default. Thus,Promise.reject
andPromise.resolve
aren’t necessary anymore, and they may cause issues like #602.Checklist 🧢
Feel free cross items ( like this
~[] item~
) if they're irrelevant to your changes.To check an item, place an
x
in the box like so:- [x] Documentation
.[ ] Documentation[ ] TestsAffected issues 🎟
Possibly fixes #602