fix: avoid infinite loop in error handlers #2647
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/7pG5JPeXpBStYfdk78Te1Y2F9X4q [Deployment for b95a46d failed] |
…uth into fix/error-handler-loop
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* fix: avoid infinite loop in error handlers * chore(dev): remove mongodb folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although a catch-all error handler like the one in
src/errorsseemed to be a good starting point, it proves to be a half-baked solution. Amongst other things, it caused the bug this PR is fixing, but it essentially also makes the error stack point to the wrong place. We will have to handle errors lower, at their root, when the adapter/event methods are called.This PR fixes a problem reported in #2622