Fix Apple Provider first and last name

[ryanmalesic]

Re-adding apple firstName and lastName. The name is not sent in the response but the fix was removed in a recent commit. This commit re-adds the logic to add the first and last name to the profile.

Reasoning 💡

The name for a user is important.

Checklist 🧢

• Documentation
• Tests
• Ready to be merged

Affected issues 🎟

Fixes the changes made in #2875

[balazsorban44]

Could you please show me the input argument of your profile callback both with and without your change in the core?

I really want to avoid putting provider specific code into the core.

[balazsorban44]

I really object this change, especially if it's Apple only.

We tested this provider a few days ago, and this wasn't necessary.

[ryanmalesic]

{
iss: '...'
aud: '...',
exp: ...,
iat: ...,
sub: '...',
at_hash: '...',
email: '[email protected]',
email_verified: 'true',
auth_time: ...,
nonce_supported: true
}

This is the contents of profile without the changes. Name is not included. Name also isn't stored in the database without the changes I made.

Documentation isn't clear but

The modified name is only shared with your app and not with Apple, and hence isn’t included in the ID token.
https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_rest_api/authenticating_users_with_sign_in_with_apple#3383768

[stale]

Hi there! It looks like this issue hasn't had any activity for a while. It will be closed if no further activity occurs. If you think your issue is still relevant, feel free to comment on it to keep it open. (Read more at #912) Thanks!

[stale]

To keep things tidy, we are closing this issue for now. If you think your issue is still relevant, leave a comment and we might reopen it. Thanks!

[gentlementlegen]

Hello!

I would like to open this thread again because indeed the name for Apple provider does not work. The information is only contained in the body, Apple does not provide it elsewhere.

Inside the body:

{
  "code": "someValue",
  "user": "{\"name\":{\"firstName\":\"Fernand\",\"lastName\":\"VEYRIER\"},\"email\":\"[email protected]\"}"
}

But later on when tokens.claims() is called, the value of the profile is the following:

{
  "iss": "https://appleid.apple.com",
  "aud": "...",
  "exp": 1646363341,
  "iat": 1646276941,
  "sub": "...",
  "at_hash": "vhu7PI4b6vTNlJvGgTE-PQ",
  "email": "[email protected]",
  "email_verified": "true",
  "auth_time": 1646276829,
  "nonce_supported": true
}

The user data is totally omitted and cannot be retrieved anymore. Would love to have an update on this, thanks!

[rogaha]

+1