-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): custom fetch options #3735
feat(react): custom fetch options #3735
Conversation
I'm not sure of the immediate security implications here, as I haven't used that setting before, but on first thought, it doesn't sound right. 🤔 |
For this to work you'd also have to have the next-auth API running under the same domain, have its cookie domain set as the apex domain and have CORS set up correctly. This merely makes it possible to tell fetch to pass the cookie that was already explicitly exposed to the site to the session API. Could you elaborate on your concerns? |
@balazsorban44 Anything I can do to get this to land? I'm dealing with some schedule pressure here :( |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/2WniLfxgJB4xVjS97aqioSnfvMRk [Deployment for 4aeaf5e canceled] |
@balazsorban44 Gentle nudge :) Anything I can do to help this land? |
eaf1b50
to
4aeaf5e
Compare
@balazsorban44 Apologies for pestering you about this but I'm still looking to get this to land. As always, let me know if there's anything more I can do to move this forward. Happy to jump on a call to run through the changes if that's easier for you. |
It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks! |
To keep things tidy, we are closing this issue for now. If you think your issue is still relevant, leave a comment and we might reopen it. Thanks! |
This is still a relevant requests. I think Next Auth JS should consider support this. |
Bump. This still seams to be one of the cleanest solution to a real problem. #2414 |
Introducing the ability to customize options passed to fetchData by passing
fetchOptions
as a prop toSessionProvider
Reasoning 💡
Primarily to facilitate setting
"credentials": "include"
in a case where a single next-auth server is serving multiple Next sites.Checklist 🧢
Affected issues 🎟
#2414