Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppManager method name #512

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix AppManager method name #512

merged 1 commit into from
Feb 14, 2025

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Feb 13, 2025

Currently, when forcing the activation of an app ("Allow untested app"), the following error is thrown:

{"reqId":"X3sNgVxzk6cwfqJqYEmk","level":3,"time":"2025-02-13T20:28:00+00:00","remoteAddr":"172.24.0.1","user":"admin","app":"index","method":"POST","url":"/index.php/apps/app_api/apps/force","message":"Call to undefined method OC\\App\\AppManager::ignoreNextcloudRequirementForApp() in file '/var/www/html/apps/app_api/lib/Controller/ExAppsPageController.php' line 448","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36","version":"32.0.0.0","exception":{"Exception":"Exception","Message":"Call to undefined method OC\\App\\AppManager::ignoreNextcloudRequirementForApp() in file '/var/www/html/apps/app_api/lib/Controller/ExAppsPageController.php' line 448","Code":0,"Trace":[{"file":"/var/www/html/lib/private/AppFramework/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/lib/private/Route/Router.php","line":306,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/html/lib/base.php","line":1034,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/html/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","Line":146,"Previous":{"Exception":"Error","Message":"Call to undefined method OC\\App\\AppManager::ignoreNextcloudRequirementForApp()","Code":0,"Trace":[{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":200,"function":"force","class":"OCA\\AppAPI\\Controller\\ExAppsPageController","type":"->"},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":114,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/lib/private/Route/Router.php","line":306,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/html/lib/base.php","line":1034,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/html/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/apps/app_api/lib/Controller/ExAppsPageController.php","Line":448},"message":"Call to undefined method OC\\App\\AppManager::ignoreNextcloudRequirementForApp() in file '/var/www/html/apps/app_api/lib/Controller/ExAppsPageController.php' line 448","exception":[],"CustomMessage":"Call to undefined method OC\\App\\AppManager::ignoreNextcloudRequirementForApp() in file '/var/www/html/apps/app_api/lib/Controller/ExAppsPageController.php' line 448"},"id":"67ae55d83f780"}

Should be backported to stable31

Because the method has been renamed in the mentioned commit.

@R0Wi R0Wi requested a review from oleksandr-nc February 13, 2025 21:59
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good catch, thank you

@oleksandr-nc oleksandr-nc merged commit 3a96c7f into main Feb 14, 2025
32 checks passed
@oleksandr-nc oleksandr-nc deleted the fix-force-method-name branch February 14, 2025 11:48
@oleksandr-nc
Copy link
Contributor

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants