Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging #51442

Merged

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Mar 12, 2025

Summary

Makes it easier to figure what exactly is wrong, given that only the value was currently logged and this was not enough to properly debug it even with an available stacktrace.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Mar 12, 2025
@provokateurin provokateurin added this to the Nextcloud 32 milestone Mar 12, 2025
@provokateurin provokateurin requested a review from a team as a code owner March 12, 2025 13:44
@provokateurin provokateurin requested review from icewind1991, Altahrim and yemkareems and removed request for a team March 12, 2025 13:44
@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin provokateurin force-pushed the fix/rich-object-strings/better-exception-messages branch from 71f8c4d to b1b21bf Compare March 12, 2025 13:49
…s more useful for debugging

Signed-off-by: provokateurin <[email protected]>
@provokateurin provokateurin force-pushed the fix/rich-object-strings/better-exception-messages branch from b1b21bf to 3c698c6 Compare March 12, 2025 13:52
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@provokateurin provokateurin enabled auto-merge March 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants