Theme: Toggle theme without passing boolean value #153
+46
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADubhlaoich
approved these changes
Feb 27, 2025
|
I do like this way of toggling, but it's too early to have such a publicly visible button for the new design. We can revisit this PR later when we're ready to do the switchover. |
Yeah, sounds good to me. I'll remove the footer stuff :) |
danielledeleo
requested changes
Feb 27, 2025
Adds new toggleTheme function, along with aliases for existing mf and useNewTheme functions Add konami code to toggle
nginx-jack
force-pushed
the
feat/nicer-theme-toggle
branch
from
0b70cd3 to
50b2ebe
Compare
|
Functionality all run fine locally, nice easter egg. Agree with Dani on releasing a way to easily change the theme in the footer. |
lamATnginx
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new toggleTheme function, along with aliases for existing mf and useNewTheme functions. These functions can now be called as toggles, instead of explicitly passing a boolean i.e.
mf()oruseNewTheme()ortoggleTheme()will toggle themes. Add aliases for mf and useNewTheme for backwards compatability.Additional toggle options
When we fully release, we should have a "preview new theme" front and centre, until then, to encourage internal testing,
Add konami code to toggle (i.e. up,up,down,down,left,right,left,right,B,A) , from any page on the site, will toggle the theme