Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma: Add vs theme to mainframe #171

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Chroma: Add vs theme to mainframe #171

merged 1 commit into from
Mar 13, 2025

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Mar 12, 2025

Add vs theme to mainframe.

This is not the final code block style, but an initial pass with the default vs theme values.

This removes the custom render-codeblock as it generated html and class references that would not work with the standard chroma theme generator. We may create another render-codeblock in future, if we require a fully custom theme to render our "fancy codeblocks".

Screenshot 2025-03-12 at 11 54 14

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@nginx-jack nginx-jack requested review from a team as code owners March 12, 2025 13:57
This removes the custom render-codeblock as it generated html and class
references that would not work with the standard chroma theme generator.
We may create another render-codeblock in future, if we require a fully
custom theme to render our "fancy codeblocks".
@nginx-jack nginx-jack force-pushed the feat/chroma-mainframe branch from 7e2185c to 7893340 Compare March 13, 2025 14:36
@nginx-jack nginx-jack merged commit 9b107c8 into main Mar 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants