Skip to content

Simple fix miss property...(class member) #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 3, 2023
Merged

Simple fix miss property...(class member) #952

merged 7 commits into from
Oct 3, 2023

Conversation

xjaja
Copy link
Contributor

@xjaja xjaja commented Oct 3, 2023

No description provided.

@nikic
Copy link
Owner

nikic commented Oct 3, 2023

This looks like spam. Please explain what you're trying to do if it isn't.

@nikic nikic closed this Oct 3, 2023
@xjaja
Copy link
Contributor Author

xjaja commented Oct 3, 2023 •
edited
Loading

Like the example below

class Foo {
    public $bar1;
    publi $foo;
    public $bar;
}

When parsed, bar1 property will miss, is there any other way to save this node? 😄 @nikic

@nikic nikic reopened this Oct 3, 2023
nikic
nikic reviewed Oct 3, 2023
View reviewed changes
Copy link
Owner

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I understand what you are trying to do now. You need to run grammar/rebuildParser.php to regenerate the parser, otherwise this will have no effect.

@xjaja @nikic
Update grammar/php7.y
508f40e 
Co-authored-by: Nikita Popov <[email protected]>
@nikic
Copy link
Owner

nikic commented Oct 3, 2023

This still needs to run grammar/rebuildParser.php to regenerate the parser.

@xjaja
Copy link
Contributor Author

xjaja commented Oct 3, 2023

Thx.

@nikic nikic merged commit 54103d8 into nikic:4.x Oct 3, 2023
nikic pushed a commit that referenced this pull request Oct 7, 2023
@xjaja @nikic
Don't drop class statements before error (#952)
8d50e9d 
When encountering a null statement (indicating that an error occurred),
retain the preceding statements. These were accidentally dropped
previously.

(cherry picked from commit 54103d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjaja @nikic