New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-initialize deques #12879

Merged

Araq merged 1 commit into nim-lang:devel from zevv:zevv-autoinit-deque

Dec 21, 2019

Contributor

zevv commented Dec 11, 2019

No description provided.

juancarlospaco reviewed

View reviewed changes

lib/pure/collections/deques.nim Outdated Show resolved Hide resolved

zevv force-pushed the zevv-autoinit-deque branch 2 times, most recently from 9929805 to 5b8f853 Compare

December 12, 2019 20:20

Contributor

planetis-m commented Dec 13, 2019

tablesimpl.nim does this differently:
First it has a template with the init code

template initImpl(result: typed, size: int)

and uses that directly in init procs. and then a second template that has the if check:

template checkIfInitialized() =
  when compiles(defaultInitialSize):
    if t.dataLen == 0:
      initImpl(t, defaultInitialSize)

which is used in [], []= and etc.

Member

Araq commented Dec 13, 2019

Yeah, I also find the tableimpl.nim way more elegant.

Araq reviewed

View reviewed changes

lib/pure/collections/deques.nim Outdated Show resolved Hide resolved

Araq reviewed

View reviewed changes

lib/pure/collections/deques.nim Outdated Show resolved Hide resolved

Araq reviewed

View reviewed changes

lib/pure/collections/deques.nim Outdated Show resolved Hide resolved

Araq reviewed

View reviewed changes

lib/pure/collections/deques.nim Outdated Show resolved Hide resolved

Member

Araq commented Dec 21, 2019

Ping @zevv

Contributor Author

zevv commented Dec 21, 2019 via email

sorry, travels and family business getting in the way...


          Auto-initialize deques

c8a10b0

zevv force-pushed the zevv-autoinit-deque branch from 5b8f853 to c8a10b0 Compare

December 21, 2019 16:07

Contributor Author

zevv commented Dec 21, 2019

Removed init on accessors, refactored to use similar structure as tablesImpl (not sure why this is better, but it is at least more consistent)

Araq merged commit 28466ce into nim-lang:devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet