Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link categories in threadlist on homepage #272

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digitalcraftsman
Copy link
Contributor

@digitalcraftsman digitalcraftsman commented Oct 16, 2020

This makes it easier for users to explore threads of a category.

@digitalcraftsman digitalcraftsman force-pushed the link-categories-on-homepage branch from c3fbf75 to d54df75 Compare October 16, 2020 16:32
@digitalcraftsman digitalcraftsman marked this pull request as draft October 16, 2020 18:47
@digitalcraftsman digitalcraftsman force-pushed the link-categories-on-homepage branch from d54df75 to c448b36 Compare October 16, 2020 18:51
@jyapayne
Copy link
Collaborator

@digitalcraftsman Looks good, but the tests are failing for you because you need to modify any selectors in tests/browsertests/categories.nim from .category-name to .category-name a

@digitalcraftsman
Copy link
Contributor Author

digitalcraftsman commented Oct 18, 2020

Thanks for your feedback Joey. I've already had a brief look at the test cases but hadn't the time so far to fix them -- hence the draft status of this PR.

@digitalcraftsman digitalcraftsman force-pushed the link-categories-on-homepage branch from c448b36 to 8f6ed97 Compare October 19, 2020 09:12
@digitalcraftsman digitalcraftsman force-pushed the link-categories-on-homepage branch from 8f6ed97 to 847d4ab Compare November 29, 2021 17:15
@digitalcraftsman
Copy link
Contributor Author

the tests are failing for you because you need to modify any selectors in tests/browsertests/categories.nim from .category-name to .category-name a

I've changed every occurrence of .category-name to .category-name a and rebased this PR as well. Though the test are still failing. The information in the build log make it a bit hard to pin point the exact location of the error. Any ideas?

@dom96
Copy link
Contributor

dom96 commented Nov 29, 2021

Looking at our other runs it seems there is some flakiness :/ https://github.com/nim-lang/nimforum/actions

I've restarted this build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants