Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ESLint to other JS files e.g. scripts, configs #129

Closed
rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #131
Closed

Apply ESLint to other JS files e.g. scripts, configs #129

rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #131
Assignees
@rosle
Labels
type : feature
Milestone
3.1.0

Comments

@rosle
Copy link
Contributor

rosle commented Sep 8, 2022

Why

Right now we're running ESLint on the src folder only, it would be nice to apply it to other JS configuration files as well.

Who Benefits?

The template users 🤓
@rosle rosle self-assigned this Sep 8, 2022
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#129] Apple ESLint to other JS files
c50e908
rosle added a commit that referenced this issue Sep 9, 2022
@rosle
[#129] Apply ESLint to other JS files
034a0ed
@rosle rosle mentioned this issue Sep 9, 2022
Merged
carryall added a commit that referenced this issue Sep 20, 2022
@carryall
Merge pull request #131 from nimblehq/feature/129-apply-eslint
0ff60bf 
[#129] Apply ESLint to other JS files e.g. scripts, configs
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#129] Apply ESLint to other JS files
fd4a5fa
@carryall carryall mentioned this issue Oct 3, 2022
Merged
@bterone bterone added this to the 3.1.0 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosle rosle

Labels
type : feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

[#129] Apply ESLint to other JS files e.g. scripts, configs nimblehq/react-templates
2 participants
@rosle @bterone