Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from @import to @use and @forward #54

Closed
carryall opened this issue Mar 29, 2022 · 1 comment · Fixed by #78
Closed

Migrate from @import to @use and @forward #54

carryall opened this issue Mar 29, 2022 · 1 comment · Fixed by #78
Assignees

Comments

@carryall
Copy link
Contributor

carryall commented Mar 29, 2022

Why

As the @import would be deprecated in a few years so we better migrate from @import to @use and @forward
so instead of @import 'variables'; we should @forward 'variables'; then when working on the project we can @use './varialbes';

Note that this would depend on the issue to replace node-sass with dart-sass to be closed first

Who Benefits?

everyone

@carryall carryall added this to the 2.2.0 milestone Mar 29, 2022
@olivierobert
Copy link
Contributor

Indeed, in addition to the deprecation, using @use and @forward allow for better namespacing of styles. However, do note that dart-sass is required as node-sass does not support this. Here is a good recap of this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants