Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the template to a scoped template #82

Closed
carryall opened this issue May 30, 2022 · 0 comments · Fixed by #89
Closed

Change the template to a scoped template #82

carryall opened this issue May 30, 2022 · 0 comments · Fixed by #89
Assignees
@carryall
Labels
type : chore
Milestone
2.3.0

Comments

@carryall
Copy link
Contributor

Why

Other Nimble's packages are all scoped packages and CRA also supports scoped templates, it would be nicer to change this template to a scoped template. To align with other packages, this template can be named @nimblehq/cra-template

Screen Shot 2565-05-30 at 15 45 57

Who Benefits?

everyone
@carryall carryall mentioned this issue May 30, 2022
Merged
@carryall carryall added this to the 2.3.0 milestone Jun 10, 2022
@carryall carryall self-assigned this Jun 10, 2022
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
[#82] Update the package name and details
4dd3bff
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
[#82] Update readme
efa828d
@carryall carryall mentioned this issue Jun 10, 2022
Merged
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
[#82] Try publish the scoped package
a4442b6
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
[#82] Publish the scoped public package
0884385
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
[#82] Fix the wrong scope name
137aea0
carryall added a commit that referenced this issue Jun 13, 2022
@carryall
[#82] Add scope to setup node
c214b0b
carryall added a commit that referenced this issue Jun 13, 2022
@carryall
[#82] Remove the scope from setup node ad we do not need scope for re…
70dfc6f 
…gistry
carryall added a commit that referenced this issue Jun 13, 2022
@carryall
Merge pull request #89 from nimblehq/chore/82-change-template-to-scop…
58caf40 
…ed-template

[#82] Change the template to a scoped template
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Update the package name and details
488e6f4
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Update readme
652a43d
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Try publish the scoped package
3b3f27f
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Publish the scoped public package
ab9457f
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Fix the wrong scope name
474f91b
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Add scope to setup node
c09bc94
carryall added a commit that referenced this issue Jul 4, 2022
@carryall
[#82] Remove the scope from setup node ad we do not need scope for re…
b8e74e8 
…gistry
@carryall carryall mentioned this issue Jul 4, 2022
Merged
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#82] Try publish the scoped package
8776b0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carryall carryall

Labels
type : chore
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

[#82] Change the template to a scoped template nimblehq/react-templates
1 participant
@carryall