Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Move the publish workflow to the right folder #83

Closed
carryall opened this issue Jun 8, 2022 · 0 comments · Fixed by #84
Closed

Fix: Move the publish workflow to the right folder #83

carryall opened this issue Jun 8, 2022 · 0 comments · Fixed by #84
Assignees
@hoangmirs
Labels
type : bug
Milestone
2.3.0

Comments

@carryall
Copy link
Contributor

carryall commented Jun 8, 2022 •
edited
Loading

Issue

From an issue #58 we added the publish job to workflow in #81 but it was in the wrong folder (/template/.github) which is within the Github workflow for the generated application

Expected

The publish job should belongs in the template Github workflow

Steps to reproduce
@carryall carryall assigned carryall and hoangmirs and unassigned carryall Jun 8, 2022
hoangmirs added a commit that referenced this issue Jun 8, 2022
@hoangmirs
[#83] Fix: Move the publish workflow to the right folder
2a3f404
@hoangmirs hoangmirs mentioned this issue Jun 8, 2022
Merged
@carryall carryall added this to the 2.3.0 milestone Jun 10, 2022
carryall added a commit that referenced this issue Jun 10, 2022
@carryall
Merge pull request #84 from nimblehq/bug/83-move-publish-workflow
718b27e 
[#83] Fix: Move the publish workflow to the right folder
carryall pushed a commit that referenced this issue Jul 4, 2022
@hoangmirs @carryall
[#83] Fix: Move the publish workflow to the right folder
07ad149
@carryall carryall mentioned this issue Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangmirs hoangmirs

Labels
type : bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

[#83] Fix: Move the publish workflow to the right folder nimblehq/react-templates
2 participants
@carryall @hoangmirs