Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the support for Add-ons #85

Closed
malparty opened this issue Jun 10, 2022 · 1 comment · Fixed by #95
Closed

Add the support for Add-ons #85

malparty opened this issue Jun 10, 2022 · 1 comment · Fixed by #95
Assignees
@carryall
Labels
type : feature
Milestone
3.0.0

Comments

@malparty
Copy link
Member

Why

Currently, we cannot ask questions to the user before generating the template. This means we are limited to core/global features.
If we want to offer optional features (e.g. UI library, different CI/CD scripts, state management, etc...), we need first the template structure to welcome questions and optional add-ons.

The main idea would be to keep our Create-React-App template and to wrap it with a CLI that could:

  1. Ask questions
  2. Generate the core cra template
  3. Manually add the selected add-ons (with npm install and copy file commands)

Who Benefits?

Template users who need more specific features ready out-of-the-box.
@malparty
Copy link
Member Author

Useful resources:

@carryall carryall added this to the 2.3.0 milestone Jun 10, 2022
carryall added a commit that referenced this issue Jun 23, 2022
@carryall
[#85] Add Lerna and move cra template inside package
11509da
carryall added a commit that referenced this issue Jun 23, 2022
@carryall
[#85] Add CLI tool
b185531
@carryall carryall mentioned this issue Jun 23, 2022
Merged
carryall added a commit that referenced this issue Jun 23, 2022
@carryall
[#85] Adjust the template path on github workflow
7ba87dc
carryall added a commit that referenced this issue Jun 23, 2022
@carryall
[#85] Add package lock file
a46223c
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Add optional flag to set version control
304e3b7
@carryall carryall removed this from the 2.3.0 milestone Jun 29, 2022
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Fix package version and add type
4a8acd0
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Move the inquirer to the beginning
4be1ed9
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Move unuse import
4a62ba1
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Use camelcase for flag and move options to const
7d470f6
carryall added a commit that referenced this issue Jun 29, 2022
@carryall
[#85] Update readme to include the optional flag
c928409
@carryall carryall self-assigned this Jul 4, 2022
@carryall carryall added this to the 2.4.0 milestone Jul 4, 2022
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Refactor cli scripts and remove flags
794d783
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Refactor cli scripts and remove flags
ff50aa5
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Refactor cli scripts and remove flags
b23a3a2
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Refactor cli scripts and remove flags
37bf566
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Refactor cli scripts and remove flags
b2971fc
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Fix spacing issues
7269e17
malparty added a commit that referenced this issue Jul 5, 2022
@malparty
[#85] Fix readme.md typos
844d78f
carryall added a commit that referenced this issue Jul 6, 2022
@carryall
Merge pull request #101 from nimblehq/feature/refactor-cli
c533ab2 
[Nimble Growth][#85] Refactor CLI code and remove flags
carryall added a commit that referenced this issue Jul 6, 2022
@carryall
[#85] Remove unuse folder
b22fd4c
carryall added a commit that referenced this issue Jul 6, 2022
@carryall
[#85] Temporary remove the publish workflow as it no longer work with…
1471d79 
… lerna
carryall added a commit that referenced this issue Jul 7, 2022
@carryall
[#85] Move const and function to separate file and override basic esl…
fb959b5 
…int rule
carryall added a commit that referenced this issue Jul 7, 2022
@carryall
[#85] Remove unuse file type from gitignore
a73f57e
carryall added a commit that referenced this issue Jul 7, 2022
@carryall
[#85] Remove oclif and oclif-typescript eslint rules
5b4245b
carryall added a commit that referenced this issue Jul 7, 2022
@carryall
[#85] Remove oclif and oclif-typescript package
0d191aa
carryall added a commit that referenced this issue Jul 7, 2022
@carryall
[#85] Rename the file and put it in a folder and rename the function
7ac330f
carryall added a commit that referenced this issue Jul 8, 2022
@carryall
[#85] Remove empty rule
f38eae3
carryall added a commit that referenced this issue Jul 11, 2022
@carryall
Merge pull request #95 from nimblehq/feature/85-add-support-for-add-ons
85dda27 
[#85] Add the support for Add-ons
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Add Lerna and move cra template inside package
24b4430
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Add CLI tool
3cdcef6
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Adjust the template path on github workflow
dfbd3a5
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Add package lock file
f1a278b
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Add optional flag to set version control
8de3d57
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Fix package version and add type
f7299b7
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Move the inquirer to the beginning
df0d9a5
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Move unuse import
c5efa6c
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Use camelcase for flag and move options to const
2f9a975
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Update readme to include the optional flag
e8315f8
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Remove unuse folder
420d0c7
carryall pushed a commit that referenced this issue Jul 25, 2022
@malparty @carryall
[#85] Refactor cli scripts and remove flags
c6416cf
carryall pushed a commit that referenced this issue Jul 25, 2022
@malparty @carryall
[#85] Fix spacing issues
392e40b
carryall pushed a commit that referenced this issue Jul 25, 2022
@malparty @carryall
[#85] Fix readme.md typos
ccd4814
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Move const and function to separate file and override basic esl…
93a35cb 
…int rule
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Remove unuse file type from gitignore
e1b31db
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Remove oclif and oclif-typescript eslint rules
1a8b9e9
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Remove oclif and oclif-typescript package
984d150
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Rename the file and put it in a folder and rename the function
997afba
carryall added a commit that referenced this issue Jul 25, 2022
@carryall
[#85] Remove empty rule
e06757f
@carryall carryall mentioned this issue Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carryall carryall

Labels
type : feature
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[#85] Add the support for Add-ons nimblehq/react-templates
2 participants
@carryall @malparty