Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support spatial normalization to alternative modalities #459

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Dec 11, 2024

Builds off #457
Requires nipreps/niworkflows#911

Adds a new parameter to init_register_template_wf(), image_type, to allow setting alternative registration targets for spatial normalization.

Also adds a tweak to the antsRegistration call to disable histogram_matching (which is enabled in most of the preset settings used), for cases where the reference anatomical and template target differ in modality.

@mgxd mgxd force-pushed the enh/normalize-t2w branch from 1f6f615 to 7d60ee8 Compare December 11, 2024 21:05
@mgxd mgxd force-pushed the enh/normalize-t2w branch from 0d0bd42 to e46fc10 Compare December 12, 2024 15:41
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (87e5e88) to head (e46fc10).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #459       +/-   ##
===========================================
+ Coverage   63.15%   74.16%   +11.00%     
===========================================
  Files          25       25               
  Lines        1938     1947        +9     
  Branches      240      242        +2     
===========================================
+ Hits         1224     1444      +220     
+ Misses        676      438      -238     
- Partials       38       65       +27     
Flag Coverage Δ
ds054 45.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd marked this pull request as ready for review December 12, 2024 15:57
@effigies
Copy link
Member

@mgxd This is passing our tests, and I'm confident it won't break non-nibabies use cases. Merge when you're comfortable.

@mgxd mgxd merged commit 9a6385b into nipreps:master Dec 12, 2024
18 checks passed
@mgxd mgxd deleted the enh/normalize-t2w branch December 12, 2024 16:21
effigies added a commit that referenced this pull request Dec 19, 2024
0.17.0 (December 19, 2024)

New feature release in the 0.17.x series.

This release improves handling of datasets where T1w images are not
the primary modality. It also supports the generation of fsLR meshes
on the subject surface with the names:

    sub-<label>/anat/sub-<label>_hemi-<L|R>_space-fsLR_den-<label>_<surface>.surf.gii

These are useful for plotting CIFTI results on subject anatomy.

* FIX: Stop excluding FS minc_modify_header used during fallback registration (#453)
* ENH: Output fsLR meshes on subject surfaces (#460)
* ENH: Support spatial normalization to alternative modalities (#459)
* ENH: Add `t2w_file` output to `TemplateFlowSelect` (#457)
* MNT: Enable pre-release tests (#461)
* MNT: Complete transition from flake8/black to ruff (#435)
* MNT: Adopt src/ layout and tox (#458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants