FIX: Fix for NumPy deprecation #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
May 17, 2018
nibabel/freesurfer/mghformat.py
Outdated
| @@ -255,7 +255,7 @@ def get_zooms(self): | |||
| .. _mghformat: https://surfer.nmr.mgh.harvard.edu/fswiki/FsTutorial/MghFormat#line-82 | |||
| ''' | |||
| # Do not return time zoom (TR) if 3D image | |||
| tzoom = (self['tr'],)[:self._ndims() > 3] | |||
| tzoom = (self['tr'],)[:int(self._ndims() > 3)] | |||
There was a problem hiding this comment.
I think I wrote this, but looking at it, I think it's only a couple characters more to be a lot clearer in intent:
tzoom = (self['tr'],) if self._ndims() > 3 else ()
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 87 87
Lines 10816 10816
Branches 1794 1794
=======================================
Hits 9768 9768
Misses 719 719
Partials 329 329
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this warning: