Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOMERGE] Revert "MRG: fix bug in get_fdata return value" #677

Closed
wants to merge 9 commits into from

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 5, 2018

This was the PR that #665 first showed up in. I want to see if somehow it actually caused these problems.

Reverts #638

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #677 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   88.86%   88.88%   +0.01%     
==========================================
  Files          93       93              
  Lines       11378    11378              
  Branches     1869     1869              
==========================================
+ Hits        10111    10113       +2     
+ Misses        930      929       -1     
+ Partials      337      336       -1
Impacted Files Coverage Δ
nibabel/dataobj_images.py 100% <0%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7877add...b67d079. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 5, 2018

Coverage Status

Coverage increased (+0.009%) to 91.835% when pulling b67d079 on revert-638-array-image-casting into 7877add on master.

@effigies
Copy link
Member Author

effigies commented Oct 6, 2018

Still failing, so I don't think it's #638.

@effigies effigies closed this Oct 6, 2018
@effigies effigies mentioned this pull request Oct 12, 2018
@effigies effigies deleted the revert-638-array-image-casting branch May 25, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants