Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG: Revert to pre-error trees and enable AppVeyor debugging #680

Closed
wants to merge 29 commits into from

Conversation

effigies
Copy link
Member

No description provided.

@yarikoptic
Copy link
Member

Restart a few times?

@effigies
Copy link
Member Author

@yarikoptic
Copy link
Member

Yeap... So should we try one more used to be ok commit a month before that one? If that one fails than most likely it is not nibabel fault, and python and/or numpy or some library

@effigies effigies force-pushed the debug/appveyor-reversion branch from 3d808c9 to 73366d9 Compare October 15, 2018 13:49
@effigies
Copy link
Member Author

Restarted, because there were files added during these intervals that don't get removed with git checkout <githash> .. That needs to be followed by a git checkout -p <githash> ..

Two targets are dfd113c (Jun 4) and 68cf671 (Apr 24).

4 build attempts on each.

@effigies effigies changed the title DEBUG: Revert to dfd113c and enable AppVeyor debugging DEBUG: Revert to pre-error trees and enable AppVeyor debugging Oct 15, 2018
@effigies
Copy link
Member Author

Ah, this may be relevant:

screen shot 2018-10-15 at 07 04 14

I think next step should be to try a range of Numpy versions, starting from 1.14.2 or so.

@effigies
Copy link
Member Author

@nibotmi
Copy link
Contributor

nibotmi commented Oct 16, 2018

☔ The latest upstream changes (presumably 1e9c4d4) made this pull request unmergeable. Please resolve the merge conflicts.

@effigies
Copy link
Member Author

Yes! Failure at last! So it's not our fault. I'll iterate over numpy releases next.

cc @yarikoptic

@effigies effigies force-pushed the debug/appveyor-reversion branch from 310778c to ea344cb Compare October 17, 2018 16:37
@effigies
Copy link
Member Author

Problem reproduces in numpy 1.14.2: https://ci.appveyor.com/project/nipy/nibabel/builds/19582043/job/8iuss25ktq30hqde?fullLog=true

Will push back a few versions, just to be sure.

@yarikoptic
Copy link
Member

whoohoo -- what a fishing expedition ;-) "love it"!

@yarikoptic
Copy link
Member

grr... only 1.12 fails similarly ... so either it is even before then, or not numpy fault

@effigies
Copy link
Member Author

Looks like probably not numpy's fault.

@nibotmi
Copy link
Contributor

nibotmi commented Dec 31, 2018

☔ The latest upstream changes (presumably #700) made this pull request unmergeable. Please resolve the merge conflicts.

@effigies
Copy link
Member Author

This effort is dead. The bug seems to be happening less lately, so hopefully whatever was going on over at AppVeyor is resolved. I think if this recurs, we should think about moving to Azure Pipelines for Windows tests.

@effigies effigies closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants