Siemens CSA Reader: Increase maximum number of items

[isolovey]

No description provided.

[isolovey]

I've encountered a file with 282 items. It might even make sense to do away with this limit altogether.

[effigies]

This seems fine to me.

A limit of 99 was added by @matthew-brett in 59dc04a and updated to 199 by @kevlarkevin in #242. Could one or both of you chime in on the original intent, and whether it makes sense to keep a fixed limit at all?

@isolovey-robarts In any event, you may want to update the test added in #242.

[matthew-brett]

No principled reason for the number, just there to avoid getting locked into parsing a broken header into the rest of the filesystem.

[coveralls]

Coverage remained the same at 91.851% when pulling 8c90a20 on isolovey-robarts:max_csa_items into ad26878 on nipy:master.

[isolovey]

Kept the limit at 1000 and fixed the tests.

[effigies]

Please merge master to fix style checks.

[codecov-io]

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          93       93           
  Lines       11449    11449           
  Branches     1892     1892           
=======================================
  Hits        10176    10176           
  Misses        933      933           
  Partials      340      340

Impacted Files	Coverage Δ
nibabel/nicom/csareader.py	84.44% <100%> (ø)	⬆️
nibabel/spatialimages.py	96.33% <0%> (ø)	⬆️
nibabel/nifti1.py	91.22% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad26878...8c90a20. Read the comment docs.

[isolovey]

Fails on testing against pre-release builds, but nothing to do with this pull request as far as I can tell.

[effigies]

I agree. Thanks!