ENH: Add NIFTI_XFORM_TEMPLATE_OTHER xform code #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 93 93
Lines 11474 11474
Branches 1992 1992
=======================================
Hits 10259 10259
+ Misses 880 879 -1
- Partials 335 336 +1
Continue to review full report at Codecov.
|
|
Added to the official |
|
Now that this is appearing in the official repository, so we have macro name confirmation, I'd like to go ahead and get this in for the 2.4 release. Anybody up for a review? |
effigies
force-pushed
the
enh/nifti_xform_template_other
branch
from
b21bd35 to
288bbf7
Compare
|
Review is looking unlikely. Here we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the proposed xform code 5. The test might be redundant, but I didn't immediately see anything that would exercise this addition, so it's just a simple verification that any defined code can be set without raising errors and retrieved reliably.
I used the macro name I proposed, but am content to revert to
NIFTI_XFORM_GEN_STANDARD, if that's the consensus.Closes #730.
cc @mrneont @afni-rickr @satra
Ref: NITRC thread 10029 - Proposed (minor) update for NIFTI sform values