Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reading an LTA generated by fMRIPrep #64

Closed
oesteban opened this issue Mar 18, 2020 · 2 comments · Fixed by #65
Closed

Issue reading an LTA generated by fMRIPrep #64

oesteban opened this issue Mar 18, 2020 · 2 comments · Fixed by #65
Milestone

Comments

@oesteban
Copy link
Collaborator

oesteban commented Mar 18, 2020

This LTA file (generated by this node) fails to load:

>>> import nitransforms as nit
>>> xfm = nit.linear.load('T1_robustreg.lta', fmt='lta')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 455, in load
    filename, fmt=fmt, reference=reference, moving=moving
  File "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 198, in from_filename
    return cls(matrix, reference=reference)
  File "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 236, in __init__
    for xfm in transforms
  File "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 236, in <listcomp>
    for xfm in transforms
  File "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 70, in __init__
    raise ValueError("Matrix does not represent a valid transform.")
ValueError: Matrix does not represent a valid transform.
@oesteban
Copy link
Collaborator Author

BTW - that transform, as per fMRIPrep, translates to ITK as this file - we should add a test checking idempotence (i.e., lta <-> itk <-> lta).

@oesteban
Copy link
Collaborator Author

It seems this is still failing at "/home/oesteban/workspace/nitransforms/nitransforms/linear.py", line 70.

oesteban added a commit to oesteban/nitransforms that referenced this issue Mar 19, 2020
oesteban added a commit to oesteban/nitransforms that referenced this issue Mar 19, 2020
@oesteban oesteban added this to the 20.0.0rc1 milestone Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant