Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add an *Installation* section #122

Merged
merged 2 commits into from
Jul 15, 2021
Merged

DOC: Add an *Installation* section #122

merged 2 commits into from
Jul 15, 2021

Conversation

oesteban
Copy link
Collaborator

Adds a new installation section that is missing and required by our JOSS submission.

References: openjournals/joss-reviews#3459

@oesteban oesteban requested a review from mgxd July 14, 2021 07:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #122 (cefd517) into master (0b36f40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          12       12           
  Lines        1084     1084           
  Branches      138      138           
=======================================
  Hits         1072     1072           
  Misses          6        6           
  Partials        6        6           
Flag Coverage Δ
travis 98.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b36f40...cefd517. Read the comment docs.

@oesteban oesteban force-pushed the docs/installation branch from 90f1217 to 1df315d Compare July 14, 2021 07:49
@robbisg robbisg mentioned this pull request Jul 14, 2021
@oesteban oesteban changed the title DOC: Add an _Installation_ section DOC: Add an *Installation* section Jul 15, 2021
@oesteban
Copy link
Collaborator Author

@mgxd any chance you can have a quick look?

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though wdyt about adding a section to verify the install?

python -c "import nitransforms as nt; print(nt.__version__)"

@oesteban
Copy link
Collaborator Author

Sure, please directly commit to this branch

@oesteban oesteban merged commit 30d3b17 into master Jul 15, 2021
@oesteban oesteban deleted the docs/installation branch July 15, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants