FIX: Increase FSL serialization precision #144
Merged
+18
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Feb 15, 2022
| @@ -46,14 +46,14 @@ def from_ras(cls, ras, moving=None, reference=None): | |||
|
|
|||
| # Adjust for reference image offset and orientation | |||
| refswp, refspc = _fsl_aff_adapt(reference) | |||
| pre = reference.affine.dot(inv(refspc).dot(inv(refswp))) | |||
| pre = reference.affine @ inv(refswp @ refspc) | |||
There was a problem hiding this comment.
I think it makes sense to think of the matrices as aff and swp @ spc. So you are always either aff @ inv(swp @ spc) or swp @ spc @ inv(aff).
|
|
||
| # Adjust for moving image offset and orientation | ||
| movswp, movspc = _fsl_aff_adapt(moving) | ||
| post = inv(movswp).dot(movspc.dot(inv(moving.affine))) | ||
| post = movswp @ movspc @ inv(moving.affine) |
There was a problem hiding this comment.
That catches that here you had movswp inverted and movspc not.
oesteban
force-pushed
the
fix/fsl_transforms
branch
from
2ca2724 to
77d93fd
Compare
oesteban
approved these changes
Feb 16, 2022
effigies
commented
Feb 16, 2022
| @@ -24,4 +24,4 @@ def assert_affines_by_filename(affine1, affine2): | |||
| else: | |||
| xfm1 = np.loadtxt(str(affine1)) | |||
| xfm2 = np.loadtxt(str(affine2)) | |||
| np.testing.assert_almost_equal(xfm1, xfm2) | |||
| np.allclose(xfm1, xfm2, atol=1e-04) | |||
There was a problem hiding this comment.
We just lost an assertion.
oesteban
added a commit
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reviewing when you merged. :-)