Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tst: skip unfinished implementation tests #15

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Oct 15, 2019

Preceeds #14

@@ -29,7 +29,7 @@ def __init__(self, field, reference=None):
self._field = field.get_data()

ndim = self._field.ndim - 1
if self._field.shape[:-1] != ndim:
if len(self._field.shape[:-1]) != ndim:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oesteban is this the intended behavior?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing so :)

@oesteban oesteban merged commit 221a43a into nipy:master Oct 16, 2019
@mgxd mgxd deleted the fix/tst branch October 31, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants