Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Uber-refactor of code style, method names, etc. #24

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Oct 22, 2019

Includes a draft implementation of #22.

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #24 into master will decrease coverage by 2.01%.
The diff coverage is 83.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   77.04%   75.03%   -2.02%     
==========================================
  Files          11       11              
  Lines         758      733      -25     
  Branches       92       95       +3     
==========================================
- Hits          584      550      -34     
- Misses        136      147      +11     
+ Partials       38       36       -2
Flag Coverage Δ
#unittests 75.03% <83.6%> (-2.02%) ⬇️
Impacted Files Coverage Δ
nitransforms/conftest.py 100% <ø> (ø) ⬆️
nitransforms/linear.py 63.49% <100%> (-6.57%) ⬇️
nitransforms/tests/test_transform.py 82.75% <100%> (-2.25%) ⬇️
nitransforms/tests/test_base.py 100% <100%> (ø) ⬆️
nitransforms/tests/test_io.py 100% <100%> (ø) ⬆️
nitransforms/nonlinear.py 39.43% <62.5%> (-4.78%) ⬇️
nitransforms/base.py 67.39% <80%> (-5.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94445d9...d31c55e. Read the comment docs.

@oesteban oesteban requested a review from mgxd October 23, 2019 00:05
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i think this makes the api cleaner and makes conversions from ras / vox spaces a bit clearer. looks good - only complaint is coverage is currently lower.

@oesteban oesteban merged commit 8d559a0 into nipy:master Oct 23, 2019
@oesteban oesteban deleted the enh/22 branch October 23, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants