Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add tests and implementation for Displacements fields and refactor linear accordingly #27

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

oesteban
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #27 into master will increase coverage by 4.9%.
The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #27     +/-   ##
========================================
+ Coverage   68.59%   73.5%   +4.9%     
========================================
  Files           5       5             
  Lines         500     434     -66     
  Branches       76      64     -12     
========================================
- Hits          343     319     -24     
+ Misses        126      91     -35     
+ Partials       31      24      -7
Flag Coverage Δ
#unittests 73.5% <70%> (+4.9%) ⬆️
Impacted Files Coverage Δ
nitransforms/nonlinear.py 64.28% <100%> (+24.84%) ⬆️
nitransforms/__init__.py 100% <100%> (ø) ⬆️
nitransforms/linear.py 62.82% <100%> (-0.68%) ⬇️
nitransforms/base.py 68.62% <57.14%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3fe80...446ce12. Read the comment docs.

@oesteban oesteban force-pushed the enh/add-more-tests branch 2 times, most recently from 8b2f20e to 68c7db6 Compare October 23, 2019 22:32
@oesteban oesteban marked this pull request as ready for review October 23, 2019 22:34
@oesteban oesteban force-pushed the enh/add-more-tests branch 4 times, most recently from 6f5d4da to 446ce12 Compare October 23, 2019 22:55
@oesteban oesteban requested a review from mgxd October 23, 2019 22:56
@oesteban oesteban force-pushed the enh/add-more-tests branch 2 times, most recently from 2c15366 to 32543c6 Compare October 23, 2019 23:09
@oesteban oesteban changed the title MAINT: Add new test to check DisplacementsFieldTransforms ENH: Add tests and implementation for Displacements fields and refactor linear accordingly Oct 23, 2019
@oesteban oesteban merged commit 6cceb63 into nipy:master Oct 23, 2019
@oesteban oesteban deleted the enh/add-more-tests branch October 23, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants