Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rename resample() with apply() #30

Merged
merged 4 commits into from
Oct 25, 2019
Merged

ENH: Rename resample() with apply() #30

merged 4 commits into from
Oct 25, 2019

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Oct 24, 2019

This PR introduces the possibility of applying transforms to images when the reference is not an image.

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #30 into master will increase coverage by 1.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   84.63%   86.07%   +1.44%     
==========================================
  Files           5        5              
  Lines         397      431      +34     
  Branches       53       60       +7     
==========================================
+ Hits          336      371      +35     
  Misses         41       41              
+ Partials       20       19       -1
Flag Coverage Δ
#unittests 86.07% <100%> (+1.44%) ⬆️
Impacted Files Coverage Δ
nitransforms/nonlinear.py 86.36% <ø> (ø) ⬆️
nitransforms/base.py 99.18% <100%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9763e62...3fbae61. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review October 24, 2019 18:30
@oesteban oesteban requested a review from mgxd October 24, 2019 18:30
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - minor comments

Co-Authored-By: Mathias Goncalves <[email protected]>
@oesteban
Copy link
Collaborator Author

Thanks very much!

@oesteban oesteban merged commit ef62bfb into nipy:master Oct 25, 2019
@oesteban oesteban deleted the fix/7 branch October 25, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants