Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rewrite load/save utilities for ITK's MatrixOffsetBased transforms in io #31

Merged
merged 4 commits into from
Oct 25, 2019

Conversation

oesteban
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 25, 2019

Hello @oesteban! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-25 18:14:50 UTC

@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #31 into master will increase coverage by 1.69%.
The diff coverage is 95.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   86.07%   87.77%   +1.69%     
==========================================
  Files           5        8       +3     
  Lines         431      507      +76     
  Branches       60       69       +9     
==========================================
+ Hits          371      445      +74     
- Misses         41       42       +1     
- Partials       19       20       +1
Flag Coverage Δ
#unittests 87.77% <95.14%> (+1.69%) ⬆️
Impacted Files Coverage Δ
nitransforms/__init__.py 100% <100%> (ø) ⬆️
nitransforms/io/__init__.py 100% <100%> (ø)
nitransforms/linear.py 70.22% <100%> (+0.44%) ⬆️
nitransforms/io/base.py 100% <100%> (ø)
nitransforms/io/lta.py 89.62% <100%> (ø)
nitransforms/io/itk.py 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef62bfb...cdc7502. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review October 25, 2019 18:10
@oesteban oesteban requested a review from mgxd October 25, 2019 18:10
@oesteban oesteban merged commit f39e6fd into nipy:master Oct 25, 2019
@oesteban oesteban deleted the enh/19 branch October 25, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants