Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: More comprehensive implementation of ITK affines I/O #35

Merged
merged 5 commits into from
Oct 28, 2019

Conversation

oesteban
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #35 into master will increase coverage by 1.61%.
The diff coverage is 99.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   90.31%   91.92%   +1.61%     
==========================================
  Files           8        8              
  Lines         506      570      +64     
  Branches       66       75       +9     
==========================================
+ Hits          457      524      +67     
+ Misses         32       30       -2     
+ Partials       17       16       -1
Flag Coverage Δ
#unittests 91.92% <99.05%> (+1.61%) ⬆️
Impacted Files Coverage Δ
nitransforms/linear.py 78.33% <100%> (-1.36%) ⬇️
nitransforms/io/itk.py 99.27% <100%> (+5.93%) ⬆️
nitransforms/io/base.py 95.65% <93.75%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a0a2f...474c85b. Read the comment docs.

@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch 2 times, most recently from f383d9d to bf7abdf Compare October 28, 2019 06:35
@pep8speaks
Copy link

pep8speaks commented Oct 28, 2019

Hello @oesteban! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-28 22:14:42 UTC

@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch 3 times, most recently from 3bf6eb2 to 426f3c6 Compare October 28, 2019 19:24
@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch from 426f3c6 to e4b93aa Compare October 28, 2019 20:04
@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch from b9777b9 to fbee5c0 Compare October 28, 2019 21:19
@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch from fcd6188 to d9e74f7 Compare October 28, 2019 21:32
@oesteban oesteban marked this pull request as ready for review October 28, 2019 21:36
@oesteban oesteban requested a review from mgxd October 28, 2019 21:36
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I think we'll have to add scipy to the requirements

EDIT: nope - it's there :)

Co-Authored-By: Mathias Goncalves <[email protected]>
@oesteban oesteban force-pushed the maint/transfrom-io-refactor branch from 0b8b3c4 to 474c85b Compare October 28, 2019 22:14
@oesteban oesteban merged commit 455f337 into nipy:master Oct 28, 2019
@oesteban oesteban deleted the maint/transfrom-io-refactor branch October 28, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants