ENH: Refactor of AFNI and FSL i/o with StringStructs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 94.08% 98.11% +4.02%
==========================================
Files 8 10 +2
Lines 575 742 +167
Branches 77 98 +21
==========================================
+ Hits 541 728 +187
+ Misses 18 7 -11
+ Partials 16 7 -9
Continue to review full report at Codecov.
|
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
4c73cd6 to
d12f86b
Compare
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
d12f86b to
65c49cd
Compare
|
Hello @oesteban! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-30 16:01:12 UTC |
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
8a64bf8 to
ec8487b
Compare
oesteban
force-pushed
the
enh/io-fsl-afni
branch
2 times, most recently
from
058792a to
223f7df
Compare
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
223f7df to
62a83aa
Compare
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
a773fa9 to
f920efa
Compare
mgxd
reviewed
Oct 30, 2019
mgxd
reviewed
Oct 30, 2019
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
6653556 to
ce64d54
Compare
Co-Authored-By: Mathias Goncalves <[email protected]>
oesteban
force-pushed
the
enh/io-fsl-afni
branch
from
ce64d54 to
71d8a57
Compare
mgxd
approved these changes
Oct 30, 2019
| not lines or | ||
| not lines[0].startswith('#') or | ||
| 'Insight Transform File V1.0' not in lines[0] | ||
| ): |
There was a problem hiding this comment.
tiny nitpick
Suggested change
| ): | |
| ): |
There was a problem hiding this comment.
flake8 doesn't like that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.