Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Base implementation of transforms chains (composition) #43

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Oct 31, 2019

Setting up the infrastructure to allow the + operator, indexed transforms, etc.

This will also set up a base for the storage of transform chains.

This PR completes the requirements promised in the preprint.

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #43 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   98.67%   98.74%   +0.07%     
==========================================
  Files          10       10              
  Lines         756      799      +43     
  Branches       98      105       +7     
==========================================
+ Hits          746      789      +43     
  Misses          6        6              
  Partials        4        4
Flag Coverage Δ
#unittests 98.74% <100%> (+0.07%) ⬆️
Impacted Files Coverage Δ
nitransforms/base.py 99.4% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a3a3b...986e9ca. Read the comment docs.

@oesteban oesteban force-pushed the enh/transform-concatenation branch from a040418 to cb7d41a Compare October 31, 2019 19:07
@oesteban oesteban requested a review from mgxd October 31, 2019 19:20
Co-Authored-By: Mathias Goncalves <[email protected]>
@oesteban oesteban merged commit ed7e8ad into nipy:master Oct 31, 2019
@oesteban oesteban deleted the enh/transform-concatenation branch October 31, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants