New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: First implementation of AFNI displacement fields #50

Merged

oesteban merged 10 commits into nipy:master from smoia:master

Nov 14, 2019

Contributor

smoia commented Nov 12, 2019

Closes #5 .

oesteban and others added 5 commits

November 12, 2019 09:53


          enh: initialize AFNI's displacements fields loader

6dff850


          Added test for AFNI nonlinear

249a2d6


          Merge branch 'enh/afni-displacementfield-reader' of https://github.co…

da129d9

…m/poldracklab/nitransforms


          Bug fixes for AFNI test

6a1c128


          Imported nibabel's loadimg

76d4c14

oesteban approved these changes

View reviewed changes

Collaborator

oesteban left a comment

This is looking great - the tests failing are related to oblique images, which is being addressed in #49 (I'll change the title of that one when I push my latest changes).

Just a minor comment to allow tests to fail 👍

nitransforms/tests/test_nonlinear.py Show resolved Hide resolved

oesteban requested a review from mgxd

November 13, 2019 13:49

mgxd approved these changes

View reviewed changes

Member

mgxd left a comment

Awesome, looks good! Super tiny nitpick

nitransforms/io/afni.py Outdated Show resolved Hide resolved


          Update nitransforms/tests/test_nonlinear.py

4f9074d

Co-Authored-By: Oscar Esteban <[email protected]>

codecov-io commented Nov 13, 2019 •

edited

Loading

Codecov Report

Merging #50 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   98.74%   98.76%   +0.01%     
==========================================
  Files          10       10              
  Lines         799      811      +12     
  Branches      105      106       +1     
==========================================
+ Hits          789      801      +12     
  Misses          6        6              
  Partials        4        4

Flag	Coverage Δ
#unittests	`98.76% <100%> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
nitransforms/io/itk.py	`100% <100%> (ø)`	⬆️
nitransforms/io/base.py	`100% <100%> (ø)`	⬆️
nitransforms/io/afni.py	`98.7% <100%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7e8ad...845f5b0. Read the comment docs.

mgxd reviewed

View reviewed changes

nitransforms/io/afni.py Outdated Show resolved Hide resolved

smoia and others added 4 commits

November 13, 2019 15:32


          Removed leading underscores

6f79b77


          Merge remote-tracking branch 'origin/master'

fa171e4


          enh: address @mgxd's comment requesting increase in coverage

527e9ee


          Merge pull request #1 from oesteban/smoia-master-patch-1

845f5b0

enh: address @mgxd's comment requesting increase in coverage

pull-assistant bot commented Nov 14, 2019

Best reviewed: commit by commit

Optimal code review plan (1 warning)

enh: initialize AFNI's displacements fields loader

...sforms/tests/test_nonlinear.py 50% changes removed in Added test for AFNI ...

Added test for AFNI nonlinear

Merge branch 'enh/afni-displacementfield-reader' of https://github.com...

Bug fixes for AFNI test

Imported nibabel's loadimg

Update nitransforms/tests/test_nonlinear.py

Removed leading underscores

Merge remote-tracking branch 'origin/master'

enh: address @mgxd's comment requesting increase in coverage

Merge pull request #1 from oesteban/smoia-master-patch-1

Powered by Pull Assistant. Last update 6dff850 ... 845f5b0. Read the comment docs.

pep8speaks commented Nov 14, 2019

Hello @smoia! Thanks for updating this PR.

In the file nitransforms/tests/test_io.py:

Line 326:1: E302 expected 2 blank lines, found 1

oesteban merged commit bd03cce into nipy:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet