Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: I/O of FSL displacements fields #51

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

smoia
Copy link
Contributor

@smoia smoia commented Nov 14, 2019

Added FSL displacements

@pull-assistant
Copy link

pull-assistant bot commented Nov 14, 2019

Score: 0.95

Best reviewed: commit by commit


Optimal code review plan

     Added FSL Displacement field class and a FSL warp

     Added nonlinear tests for FSL

     corrected inversion of axes and fieldmap creation in fsltest

Powered by Pull Assistant. Last update 0427f9e ... b50f24b. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #51 into master will decrease coverage by 0.83%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   98.76%   97.92%   -0.84%     
==========================================
  Files          10       10              
  Lines         810      820      +10     
  Branches      106      107       +1     
==========================================
+ Hits          800      803       +3     
- Misses          6       10       +4     
- Partials        4        7       +3
Flag Coverage Δ
#unittests 97.92% <60%> (-0.84%) ⬇️
Impacted Files Coverage Δ
nitransforms/io/fsl.py 90.69% <60%> (-4.11%) ⬇️
nitransforms/io/afni.py 96.1% <0%> (-2.6%) ⬇️
nitransforms/base.py 98.8% <0%> (-0.6%) ⬇️
nitransforms/io/itk.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec1eb3...b50f24b. Read the comment docs.

@smoia smoia force-pushed the enh/fsl-displacementfield branch from 331f3b6 to b50f24b Compare November 14, 2019 22:30
@pep8speaks
Copy link

pep8speaks commented Nov 14, 2019

Hello @smoia! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-16 16:33:44 UTC

@smoia
Copy link
Contributor Author

smoia commented Nov 15, 2019

All the tests pass, except for test_displacements_field1, parametrised with sw_tool='fsl', image_orientation='LPS', for axis cases 0, 1, (0,1), (1, 2), (0, 1, 2) (but pass for axis=2).

@oesteban
Copy link
Collaborator

Note: perhaps some inspiration form fslpy (#99) could help with this one - https://open.win.ox.ac.uk/pages/fsl/fslpy/fsl.transform.nonlinear.html#module-fsl.transform.nonlinear

@oesteban oesteban force-pushed the enh/fsl-displacementfield branch from b50f24b to adf63d5 Compare February 16, 2022 16:33
@oesteban oesteban marked this pull request as ready for review February 16, 2022 17:44
@oesteban oesteban changed the title ENH: fsl displacementfield ENH: I/O of FSL displacements fields Feb 16, 2022
@oesteban oesteban merged commit 37f045e into nipy:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants