Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: facilitate displacementsfield transform loading #54

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Dec 2, 2019

adds load functionality for nonlinear transforms similar to linear.

Will need to be revised once BSplineFieldTransform is re-added

@pull-assistant
Copy link

pull-assistant bot commented Dec 2, 2019

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     enh: facilitate displacementsfield transform loading

Powered by Pull Assistant. Last update 77f983c ... 77f983c. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   98.76%   98.77%   +0.01%     
==========================================
  Files          10       10              
  Lines         810      819       +9     
  Branches      106      107       +1     
==========================================
+ Hits          800      809       +9     
  Misses          6        6              
  Partials        4        4
Flag Coverage Δ
#unittests 98.77% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nitransforms/nonlinear.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec1eb3...77f983c. Read the comment docs.

@mgxd mgxd requested a review from oesteban December 3, 2019 17:02
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@oesteban oesteban merged commit 9bfa598 into nipy:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants