-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Better config on setup.py (binary operator starting line) #60
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 11 11
Lines 868 868
Branches 111 111
=======================================
Hits 858 858
Misses 6 6
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
@@ -33,5 +33,22 @@ console_scripts = | |||
nt = nitransforms.cli:main | |||
|
|||
[flake8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we plan on porting this over to nibabel, let's revert the style checks to match theirs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh right. We might want to push for more strict flake8 checks. @effigies ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go-ahead - good syntax should not be a problem when integrating into nibabel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. I saw this on my notifications and then it disappeared. Yeah, we can improve things in nibabel, but being more strict here can't cause problems.
Co-Authored-By: Mathias Goncalves <[email protected]>
No description provided.