Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Drop Python 3.5 #77

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Conversation

oesteban
Copy link
Collaborator

No description provided.

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     maint: drop Python 3.5

Powered by Pull Assistant. Last update f7f216d ... f7f216d. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #77 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   98.63%   98.68%   +0.05%     
==========================================
  Files          11       11              
  Lines         951      992      +41     
  Branches      129      129              
==========================================
+ Hits          938      979      +41     
  Misses          7        7              
  Partials        6        6
Flag Coverage Δ
#unittests 98.68% <ø> (+0.05%) ⬆️
Impacted Files Coverage Δ
nitransforms/io/itk.py 100% <0%> (ø) ⬆️
nitransforms/io/base.py 100% <0%> (ø) ⬆️
nitransforms/io/lta.py 99.34% <0%> (+0.01%) ⬆️
nitransforms/linear.py 96.1% <0%> (+0.02%) ⬆️
nitransforms/base.py 99.46% <0%> (+0.04%) ⬆️
nitransforms/io/afni.py 98.75% <0%> (+0.04%) ⬆️
nitransforms/io/fsl.py 94.93% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a99841...f7f216d. Read the comment docs.

@oesteban oesteban requested a review from mgxd March 20, 2020 15:14
@mgxd
Copy link
Member

mgxd commented Mar 20, 2020

Are we still planning on merging this with nibabel? This pushes ahead of it

@oesteban
Copy link
Collaborator Author

I've thought about that. By the time this can be merged into nibabel, I bet the support will be for +3.6 only. Otherwise, I think it is worth making the development more agile and figure out when the time comes to join both projects.

@oesteban oesteban merged commit 57f0f71 into nipy:master Mar 20, 2020
@oesteban oesteban deleted the maint/drop-python3.5 branch March 20, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants