Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: add docker image/circle build #80

Merged
merged 4 commits into from
Mar 26, 2020
Merged

MAINT: add docker image/circle build #80

merged 4 commits into from
Mar 26, 2020
+422 −0

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Mar 25, 2020 •
edited by oesteban
Loading

Closes #68

TODO:

  • Test build
  • Add docker / twine credentials
  • Release

Sorry, something went wrong.

@pull-assistant
Copy link

pull-assistant bot commented Mar 25, 2020 •
edited
Loading

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan

     MAINT: add docker image/circle build

     fix: syntax

     Update .circleci/config.yml

     Update .circleci/config.yml

Powered by Pull Assistant. Last update 5235b2b ... d550f9f. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          11       11           
  Lines         992      992           
  Branches      129      129           
=======================================
  Hits          981      981           
  Misses          6        6           
  Partials        5        5
Flag Coverage Δ
#unittests 98.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439354a...d550f9f. Read the comment docs.

oesteban
oesteban reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there.

@oesteban
Copy link
Collaborator

(I've just added the required credentials)

mgxd and others added 2 commits March 26, 2020 00:01
@mgxd @oesteban
Update .circleci/config.yml

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b6809d9 
Co-Authored-By: Oscar Esteban <[email protected]>
@mgxd @oesteban
Update .circleci/config.yml

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d550f9f 
Co-Authored-By: Oscar Esteban <[email protected]>
@oesteban oesteban merged commit 7002571 into nipy:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make nitransforms pip installable
3 participants
@mgxd @codecov-io @oesteban